Skip to content

Conversation

@C-D-Lewis
Copy link
Contributor

@C-D-Lewis C-D-Lewis commented Jun 1, 2021

Same pattern as for evrythng.js, as opposed to current way that creates a global value.

Changes:

  • Add separate 'node-style' build output, allowing import ScanThng from 'scanthng'; instead of <script>
  • Existing use of <script> should still work. (TODO: test this)
  • Don't use window to access evrythng and jsQR
  • Require evrythng and jqQR explicitly, allowing use of User scope.

Problems:

  • Bundle size increases from 13K to 183K-333K depending on import method due to including evrythng and jsQR directly.
  • evrythng.settings inside scanthng.js is not affected by evrythng.setup() called in the implementing app...

@C-D-Lewis C-D-Lewis changed the title Begin requirable version Remove peer deps, allow use of 'import' Jun 4, 2021
@C-D-Lewis C-D-Lewis closed this Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants